Repository navigation
[docs] Avoid viewport units on animated modal demo parts - #6124
Merged
Merged
Conversation
atomiks
added
docs
commit: |
Bundle size
PerformanceNo regressions in 36 benchmarks · ran 3m 50s · details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
marked this pull request as ready for review
October 28, 2026 10:44
atomiks
requested review from
aarongarciah,
colmtuite,
flaviendelangle and
michaldudak
as code owners
October 28, 2026 10:44
atomiks
force-pushed
the
docs-modal-demo-viewport-units
branch
from
November 10, 2026 04:55
ba2cac9 to
40ad5f6
Compare
atomiks
enabled auto-merge (squash)
November 10, 2026 04:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #6119
In Safari 27 with classic scrollbars, a WebKit regression drops running CSS transitions on elements that use viewport units when the scroll lock is released, so the Dialog, AlertDialog and Drawer demos skipped their exit animations. This PR replaces the viewport units on the animated popups and backdrops with
%, and moves the originaldvh/vhvalues into the existing iOS-only@supports (-webkit-touch-callout: none)blocks so iOS is unchanged. The outside scroll dialog demo keeps100dvhbecause its slide distance is viewport-based by design.